Revert "Revert changes that break material system renderer (#1648)" + fix#1649
Merged
VReaperV merged 2 commits intoDaemonEngine:masterfrom Apr 18, 2025
Merged
Revert "Revert changes that break material system renderer (#1648)" + fix#1649VReaperV merged 2 commits intoDaemonEngine:masterfrom
VReaperV merged 2 commits intoDaemonEngine:masterfrom
Conversation
Member
|
This makes the Pulse big water room on the material system appear more similar to the core renderer. I wonder if there is a bug fix or just some sort of surface ordering randomness. LGTM Core renderer:
Material system on master:
Material system with this PR:
|
slipher
approved these changes
Apr 18, 2025
Contributor
Author
Yeah, it could be due to ordering + the fact that transparent surfaces are currently not sorted in material system (well, they aren't sorted by distance in the core renderer either, but they might just end up looking more correct with the shader/lightmap/etc sorting it does). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to fix the issue, at least I can no longer reproduce it by switching around maps/doing
vid_restart.